Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/clean_shutdown #222

Merged
merged 1 commit into from
Apr 30, 2024
Merged

hotfix/clean_shutdown #222

merged 1 commit into from
Apr 30, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 30, 2024

missed in #195 refactor

Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]: 2024-04-29 20:29:55.546 - HiveMind-voice-sat - ovos_config.config:_on_file_change:317 - ERROR - Error in config update callback handler
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]: Traceback (most recent call last):
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_config/config.py", line 315, in _on_file_change
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:     handler()
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_audio/service.py", line 342, in _maybe_reload_tts
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:     self.tts.shutdown()
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_plugin_manager/templates/tts.py", line 721, in shutdown
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:     TTS.playback.detach_tts(self)
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]:     ^^^^^^^^^^^^^^^^^^^^^^^
Apr 29 20:29:55 mark1 hivemind-voice-sat[2167]: AttributeError: 'PlaybackThread' object has no attribute 'detach_tts'

missed in #195 refactor
@JarbasAl JarbasAl added the bug Something isn't working label Apr 30, 2024
@JarbasAl JarbasAl requested a review from goldyfruit April 30, 2024 02:22
@JarbasAl JarbasAl merged commit da0bbeb into dev Apr 30, 2024
8 checks passed
@JarbasAl JarbasAl deleted the hotfix/clean_shutdown branch April 30, 2024 02:30
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant