Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/py3.12 #231

Merged
merged 1 commit into from
May 19, 2024
Merged

fix/py3.12 #231

merged 1 commit into from
May 19, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 19, 2024

setuptools needs to be explicitly installed now, or OPM fails to scan plugins

    from ovos_plugin_manager.templates.solvers import QuestionSolver
  File "/home/miro/PycharmProjects/ovos-MoS/.venv/lib/python3.12/site-packages/ovos_plugin_manager/__init__.py", line 1, in <module>
    from ovos_plugin_manager.utils import PluginTypes
  File "/home/miro/PycharmProjects/ovos-MoS/.venv/lib/python3.12/site-packages/ovos_plugin_manager/utils/__init__.py", line 19, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

setuptools needs to be explicitly installed now, or OPM fails to scan plugins
@JarbasAl JarbasAl added the packaging dependency updates or packaging changes label May 19, 2024
@JarbasAl JarbasAl requested review from goldyfruit, a team and mikejgray May 19, 2024 21:13
Copy link
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point worth seeing if there's a replacement in the standard library? Until then, a welcome fix!

@JarbasAl JarbasAl merged commit 7ea03f8 into dev May 19, 2024
8 checks passed
@JarbasAl JarbasAl deleted the fix/py3.12 branch May 19, 2024 21:43
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging dependency updates or packaging changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants