-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ERC721ReceiverComponent #945
Document ERC721ReceiverComponent #945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, sir! I left a few suggestions—the biggest one being that we combine the snake and camel embeddable blocks into a single embeddable block. I think we can update Creating a token receiver contract to use ERC721ReceiverMixinImpl as well to clean up the snippet. WDYT?
…eat/document-erc721receiver-#913
The only issue I see with the approach is inconsistency. For example, the ERC721 in the same page is not using mixins, and I think we should update that as well. Let's let it for a different issue if you agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple more small suggestions and they need to be applied in #941 as well. This looks good to me otherwise
Co-authored-by: Andrew Fleming <[email protected]>
Co-authored-by: Andrew Fleming <[email protected]>
Fixes #913
This PR adds the missing documentation for the ERC721ReceiverComponent, and also
fixes the name of the mixin implementation.
PR Checklist