Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Calldata library with emptyBytes and emptyString functions #5422

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 9, 2025

Currently defined in

  • draft-ERC4337Utils.sol (contracts)
  • ERC7821.sol (community-contracts)
  • ERC7739Utils.sol (community-contracts)

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: abd1097

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ernestognw
ernestognw previously approved these changes Jan 10, 2025
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging to update community contracts.

EDIT: I realize we need a changeset

@ernestognw ernestognw changed the title Add a Calldata library to host otherwise duplicated emptyCalldataBytes and emptyCalldataString. Add a Calldata library with emptyBytes and emptyString functions Jan 10, 2025
@ernestognw ernestognw merged commit 352ab13 into OpenZeppelin:master Jan 10, 2025
15 checks passed
@Amxx Amxx deleted the utils/calldata branch January 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants