feat: Erc20Wrapper extension #498
Conversation
Ifechukwudaniel
requested review from
bidzyyys,
qalisander and
0xNeshi
as code owners
✅ Deploy Preview for contracts-stylus canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
There was a problem hiding this comment.
Good progess @Ifechukwudaniel, please focus on now:
- Increasing E2E test coverage
- Improving Rust docs
- Solving all clippy warnings.
| // ============================================================================ | ||
|
|
||
| #[e2e::test] | ||
| async fn constructs(alice: Account) -> Result<()> { |
There was a problem hiding this comment.
Increase E2E test coverage.
| //! number of "wrapped tokens". This is useful in conjunction with other | ||
| //! modules. | ||
| //! | ||
| //! WARNING: Any mechanism in which the underlying token changes the {balanceOf} |
There was a problem hiding this comment.
Adjust the docs to the current implementation. We do not have balanceOf function.
| #[allow(missing_docs)] | ||
| error ERC20InvalidUnderlying(address token); | ||
|
|
||
| /// Indicates that the address is not an Invalid Sender address. |
There was a problem hiding this comment.
I believe there is sth wrong with this docs...
| #[allow(missing_docs)] | ||
| error ERC20InvalidSender(address sender); | ||
|
|
||
| /// Indicates that The address is not a valid Invalid Asset. |
There was a problem hiding this comment.
I believe there is sth wrong with this docs...
| } | ||
| } | ||
|
|
||
| // TODO: Add missing tests once `motsu` supports calling external contracts. |
There was a problem hiding this comment.
We should have motsu version that support calling external contracts tomorrow :)
It is already merged into main branch of mostu. You can implement these test cases.
There was a problem hiding this comment.
Implement missing E2E test cases. Each scenario must be covered.
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
test
Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Daniel Bigos <[email protected]>
|
I have been kind of on another project, but I will do my best to round this up asap |
Co-authored-by: Daniel Bigos <[email protected]>
Resolves #354
PR Checklist