-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding some handlebar examples to README #290
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -32,4 +32,125 @@ The built in compiler remains solc 0.6, but users who want to use the newer comp | |||||
``` | ||||||
npm install -D solc-0.7@npm:solc@^0.7.0 | ||||||
npx solidity-docgen --solc-module solc-0.7 | ||||||
``` | ||||||
|
||||||
|
||||||
## Example Handlebars Formatting | ||||||
|
||||||
Each of the following examples will go through various methods exposed by the solidity-docgen library, how to use them in handlebars, and what the resulting markdown output would look like. | ||||||
|
||||||
1. Getting the natspec @dev and @notice tags | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is getting rendered as a numbered list and I think we want them to look more like headings, so I would go with:
Suggested change
And we should increase the nesting of the two subsections in each of these. |
||||||
|
||||||
### Handlebars formatting: | ||||||
|
||||||
``` {{{natspec.userdoc}}} | ||||||
{{{natspec.devdoc}}} | ||||||
``` | ||||||
Comment on lines
+46
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GitHub doesn't let me leave a suggestion for this, but the first line of each of these code blocks is not being displayed in the Markdown rendering. The first line needs to be on its own line, like so: ```handlebars {{{natspec.userdoc}}} {{{natspec.devdoc}}} ``` If we add |
||||||
|
||||||
### Markdown output: | ||||||
|
||||||
This is the comment next to the @notice tag. | ||||||
This is the comment next to the @dev tag. | ||||||
Comment on lines
+52
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should display the output in a code block as well, so like:
|
||||||
|
||||||
|
||||||
2. Functions and Events | ||||||
Your handlebars template can check if the underlying contract code is a function or an event with {{#if ownFunctions}} and {{#if ownEvents}} respectively. This lets you generate different markdown depending on if the underlying natspec is for functions or events. Use {{ownFunctions}} and {{ownEvents}} to iterate over all functions and events in the contract respectively. | ||||||
|
||||||
### Handlebars formatting: | ||||||
``` {{#if ownFunctions} | ||||||
### Functions | ||||||
{{/if}} | ||||||
{{#ownFunctions}} | ||||||
- function {{name}} | ||||||
{{/ownFunctions}} | ||||||
{{/if ownFunctions}} | ||||||
``` | ||||||
|
||||||
|
||||||
### Markdown Output: | ||||||
|
||||||
### Functions | ||||||
- function example1 | ||||||
- function example2 | ||||||
- function example3 | ||||||
|
||||||
3. Getting more data about a funcion | ||||||
|
||||||
In 2. we saw how to iterate over the functions in a contract and each of the function names. Here is an example that gets more information related to a function including the input parameters, and visibility. | ||||||
|
||||||
### Handlebars formatting: | ||||||
|
||||||
``` {{#if ownFunctions} | ||||||
### Functions | ||||||
{{/if}} | ||||||
{{#ownFunctions}} | ||||||
#### function {{name}} | ||||||
Parameters: | ||||||
{{natspec.params}} | ||||||
- {{param}} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great to also include the description.
Suggested change
|
||||||
{{/natspec.params}} | ||||||
Visibility: | ||||||
- {{visibility}} | ||||||
{{#if outputs}} | ||||||
Outputs: | ||||||
- {{outputs}} | ||||||
{{/if}} | ||||||
{{/ownFunctions}} | ||||||
{{/if ownFunctions}} | ||||||
``` | ||||||
|
||||||
### Markdown Output: | ||||||
|
||||||
### Functions | ||||||
#### function example1 | ||||||
Parameters: | ||||||
- param1 | ||||||
- param2 | ||||||
Visibliity: | ||||||
- external | ||||||
Outputs: | ||||||
- bool return1 | ||||||
|
||||||
#### function example2 | ||||||
Parameters: | ||||||
- param1 | ||||||
- param2 | ||||||
- param3 | ||||||
Visibliity: | ||||||
- internal | ||||||
Outputs: | ||||||
- uint128 return0, uint128 return1 | ||||||
|
||||||
#### function example3 | ||||||
Parameters: | ||||||
- param1 | ||||||
Visibliity: | ||||||
- external | ||||||
Outputs: | ||||||
- int24 return1 | ||||||
|
||||||
4. Formatting a function signature | ||||||
The nice thing about handlebars templating is that it just populates data into a markdown format. So you can use any markdown syntax to arrange your data such that it looks pretty when the markdown is generated! (The below does some fancy handlebar manipulation that you don't really need to understand. It essentially is populating the types of the parameters so that the output in markdown looks like a function signature.) | ||||||
|
||||||
### Handlebars formatting: | ||||||
``` | ||||||
### {{name}} | ||||||
```solidity | ||||||
function {{name}}( | ||||||
{{#natspec.params}} | ||||||
{{#lookup ../args.types @index}}{{/lookup}} {{param}}{{#if @last}}{{else}},{{/if}} | ||||||
{{/natspec.params}} | ||||||
) {{visibility}}{{#if outputs}} returns ({{outputs}}){{/if}}``` | ||||||
|
||||||
``` | ||||||
|
||||||
### Markdown Output: | ||||||
Here is what the output for the example1 function would look like. | ||||||
|
||||||
### example1 | ||||||
```solidity | ||||||
function example1( | ||||||
int24 param1, | ||||||
int24 param2 | ||||||
) external returns (bool return1) | ||||||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.