Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): update height prop in InfoScreen #17236

Merged
merged 3 commits into from
Jan 14, 2025
Merged

refactor(components): update height prop in InfoScreen #17236

merged 3 commits into from
Jan 14, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 9, 2025 •
edited
Loading

Overview

This is a part of DS work.
update height prop in InsoScreen and update tests

close AUTH-

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

refactor(components): update height props in InfoScreen
d8a35e9 
update height prop in InsoScreen and update tests

close AUTH-
@koji koji requested review from ncdiehl11 and jerader January 9, 2025 23:23
@koji
Copy link
Contributor Author

koji commented Jan 9, 2025 •
edited
Loading

  • check app and pd

@koji koji marked this pull request as ready for review January 10, 2025 17:07
@koji koji requested a review from a team as a code owner January 10, 2025 17:07
@koji koji removed the request for review from a team January 10, 2025 17:36
ncdiehl11
ncdiehl11 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's smoke test in some places across the app and PD, but looks fine to me

jerader
jerader approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koji koji requested a review from a team as a code owner January 14, 2025 16:14
@koji koji merged commit 9b3b33f into edge Jan 14, 2025
36 checks passed
@koji koji deleted the feat_infoscreen-support-flexible-height branch January 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koji @ncdiehl11 @jerader