Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hymba and DoRA support #919

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add Hymba and DoRA support #919

merged 4 commits into from
Dec 2, 2024

Conversation

Dominic789654
Copy link
Contributor

No description provided.

@shizhediao
Copy link
Contributor

shizhediao commented Dec 2, 2024 •
edited
Loading

Hi @Dominic789654 ,
Thanks for your hard work! The code looks great to me. Just a few comments:

  1. Can we add a self-contained script to run hymba fine-tuning at experimental/Hymba? It is just the run_finetune.sh with the hymba arguments.
  2. Do you think it is better to include the loss curve for sharing?

@research4pan Really appreciate it if you could take a look and suggest. Thanks!

Thanks!

@shizhediao
Copy link
Contributor

Thank you so much for your hard work! Looks great to me!

@shizhediao shizhediao merged commit 4b3927f into OptimalScale:main Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhediao shizhediao shizhediao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominic789654 @shizhediao