Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usability] Add hymba lora target #924

Merged
merged 3 commits into from
Dec 24, 2024
Merged

[usability] Add hymba lora target #924

merged 3 commits into from
Dec 24, 2024

Conversation

wheresmyhair
Copy link
Collaborator

  1. Fix lora_target_modules parsing issue
  2. Add (recommended) hymba lora target

shizhediao
shizhediao approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@shizhediao shizhediao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shizhediao shizhediao merged commit 9a9957d into main Dec 24, 2024
2 checks passed
shizhediao added a commit that referenced this pull request Dec 24, 2024
@shizhediao @wheresmyhair
[usability] Add hymba lora target (#924) (#925)
a6c5ae2 
* [usability] add hymba lora target

* [usability] add hymba lora target

* typo fix

---------

Co-authored-by: Yizhen Jia <[email protected]>
Co-authored-by: YizhenJia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhediao shizhediao shizhediao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wheresmyhair @shizhediao