feat(lib)!: Remove ODS Charts mode option. Use [data-bs-theme] #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacques-lebourgeois
force-pushed
the
remove_mode
branch
from
26ff592 to
99dd54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove mode parameter. just use [data-bs-theme].
Motivation & Context
There was duplication between [data-bs-theme] and mode. We don't need anymore to manage a mode inside ODS Charts and 3 colors set (default/light/dark). Just default mode based on [data-bs-theme] and css variables is now used.
Types of change
Test checklist
Please check that the following tests projects are still working:
docs/examplestest/angular-ngx-echartstest\angular-ng-boostedtest/angular-echartstest/htmltest/reacttest/vuetest/examples/bar-line-charttest/examples/single-line-charttest/examples/timeseries-chart