-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Upgrade to Sanity V3 #165
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for keen-davinci-769980 canceled.
|
❌ Deploy Preview for verdant-souffle-6c4e17 failed.
|
❌ Deploy Preview for romantic-ride-755295 failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki I have some things I noticed! But super nice that we have somebody working on this now 🎆
U have added new dependencies at root in the project, when this repo is split into two separate project (/sanity) and (/frontend), so everything sanity related should be done in /sanity.
the .sanity folder should be added to the .gitignore
also seems like someone once used yarn at root in the project, the yarn.lock there can just be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.sanity is still checked in, and even more packages was added to package.json 😬 this can all be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm there is still a very huge diff on the package-lock.json file in the root of the project, did u remember to run npm i
after removing the dependencies from package.json? 🤔
but other than that I think ur good! but you should check the logs from netlify and try to figure out why everything is red 🔴 |
OBS OBS VÆR EKSTREMT SKEPTISK