-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy 119 and 120 - Curve Pool Booster Mainnet and Arbitrum #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
requested review from
sparrowDom,
DanielVF,
naddison36 and
shahthepro
as code owners
January 27, 2025 08:28
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## clement/pool-booster-curve #2367 +/- ##
==============================================================
- Coverage 51.93% 51.31% -0.63%
==============================================================
Files 92 92
Lines 4513 4513
Branches 1195 1195
==============================================================
- Hits 2344 2316 -28
- Misses 2166 2194 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
naddison36
merged commit Jan 30, 2025
33cebda
into
clement/pool-booster-curve
12 of 20 checks passed
naddison36
added a commit
that referenced
this pull request
Jan 30, 2025
* feat: Implement Curve Pool Booster. * feat: Add proxy for Curve Pool Booster. * feaat: prepare deployment file for Curve Pool Booster. * feat: add deployment file for Curve Pool Booster. * feat: Add more test. * Revert "Merge remote-tracking branch 'origin/master' into clement/pool-booster-curve" This reverts commit b3de3b0, reversing changes made to e65f962. * fix: bring back latest changes on master. * Fix tests * feat: send ETH back. * feat: Add events. * feat: rescue tokens. * feat: add possiblity to blacklist users. * feat: add convex vecrv voter. * prettier * feat: Add fee. * fix: adjust deploy number. * fix: adjust deployment file with new Curve Pool. * feat: add new curve pool/gauge. * fix: use `Strategizable`instead of operator. * prettier. * fix: adjust event names. * docs: add natspec to functions. * fix: prevent `feeCollector` to be address(0). * fix: use `call` instead of `transfer` for ETH. * fix: use internal logic for setters. * fix: adjust event name. * fix: cache balance for gas. * fix: ensure receiver is not address(0). * fix: type adjustment. * fix: emit event when fees are collected. * fix: add onlyGovernor for initialization. * fix: use safeApprove. * fix: add natspec. * fix: group logic. * fix: use multichain strategist. * prettier. * fix: adjust deployment number. * fix: adjust comments. * fix: change from BASE_FEE to FEE_BASE. * fix: add reentrancy blocker. * fix: handle rebasing token for fees. * linter + prettier. * Add `closeCampaign()` to CurvePoolBooster. (#2360) * feat: add closeCampaign function to CurvePoolBooster. * fix: remove immutable from campaignRemoteManager. * fix: adjust naming and prettier. * feat: configure deploymment with CreateX. * fix: use encodeFunctionData to encodeWithSignature. * feat: add arbitrum deployment file for CurvePoolBooster. * feat: create a funciton for encodedSalt. * feat: create multichainStrategist variable. * fix: change proxy owner. * try something. * fix: adjust with new CampaignRemoteManager. * fix merge conflit. * fix: add more tests. * feat: add extra test for Curve Pool Booster. * prettier. * fix: add missing`nonReentrant`. * fix: approve 0 before approving. * fix: gas optimization. * fix: adjust salt. * Ran prettier for js files * Fixed deployName in Arb deploy of Pool Booster * Deploy 119 and 120 - Curve Pool Booster Mainnet and Arbitrum (#2367) * fix: adjust deployName. * fix: deploy 119 and 120. * feat: add safeTransfer for USDT. * fix: adjust deployed address for CurvePoolBooster. * fix: simplidy tests. * Fixed Arb deploy script of Curve Pool Booster * FIxed forked coverage tests * Disabled OUSD AMO fork tests * Fixed CurvePoolBooster fork test * Fixed SimpleHarvester fork tests --------- Co-authored-by: Shahul Hameed <[email protected]> Co-authored-by: Domen Grabec <[email protected]> Co-authored-by: Nicholas Addison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deploy on Mainnet and Arbitrum: Curve Pool Booster.
Dependencies:
Deployment:
119_pool_booster_curve.js
120_pool_booster_curve.js
Contracts:
Governance
Deploy checklist
Two reviewers complete the following checklist: