Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference OrleansSDK using $(OrleansSDK) property. #4

Closed
wants to merge 1 commit into from

Conversation

ReubenBond
Copy link

Currently the project assumes a directory layout which may not hold for some users. Instead, I propose we use the $(OrleansSDK) property, which is used in the file copy process.

For systems which don't have the Orleans SDK installed (eg, build servers), the SDK can be included in the solution directory and referenced by including a small MSBuild file.

IncludeOrleansSDK.targets:

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
    <PropertyGroup>
        <OrleansSDK>$(MSBuildThisFileDirectory)\Dependencies\Orleans\SDK</OrleansSDK>
    </PropertyGroup>
</Project>

@danielmarbach
Copy link
Member

Thanks perfect!

@danielmarbach
Copy link
Member

Merged fa772da into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants