Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Env overrides for all standard config values #15

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

forslund
Copy link
Contributor

This adds env overrides for the missing config options (excluding "extras") and may possibly resolve #12.

To note: OVOS_BUS_USE_SSL will set the ssl-flag if the environment variable exists. The parsing of bools seemed a bit limited using the standard .parse() so instead of requiring it to be EXACTLY true this felt like a more safe way.

Copy link
Collaborator

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to hold off on merging until I get an automated release mechanism in place, should be by EOW 🙂

README.md Show resolved Hide resolved
@mikejgray
Copy link
Collaborator

@forslund
Copy link
Contributor Author

I've fixed the clippy issues but got trouble with the tests running in parallell despite the "[serial]" attribute. (this worked last week!) so I also updated the CI-config to only use a single thread.

@mikejgray mikejgray changed the title Config: Env overrides for all standard config values feat(config): Env overrides for all standard config values Dec 12, 2024
@mikejgray
Copy link
Collaborator

I've fixed the clippy issues but got trouble with the tests running in parallell despite the "[serial]" attribute. (this worked last week!) so I also updated the CI-config to only use a single thread.

Thanks for taking care of that. I got the automated release workflow in place but unfortunately it created a conflict. If you wouldn't mind resolving that I'll go ahead and merge this in and we'll release 1.1

New environment variables:
- `OVOS_BUS_ROUTE` (default: `/core`)
- `OVOS_BUS_USE_SSL` (default: `false`) NOTE: If the environment variable exists SSL will be enabled.
@forslund forslund force-pushed the more-envs branch 3 times, most recently from d645815 to 4f79b88 Compare December 12, 2024 19:11
@forslund forslund marked this pull request as draft December 12, 2024 19:12
@forslund forslund marked this pull request as ready for review December 12, 2024 19:16
@forslund
Copy link
Contributor Author

The tests seem to have been completely removed. I've added them back as a separate github action yaml

@mikejgray mikejgray merged commit 1e4a5e2 into OscillateLabsLLC:dev Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Expose all configuration items as environment variables
2 participants