Release/0.0.3 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lrosenfeldt
reviewed
Aug 13, 2024
| @@ -4,5 +4,6 @@ | |||
| # But include these files and directories | |||
| !package.json | |||
| !README.md | |||
| !LICENSE | |||
ehrdi
approved these changes
Aug 13, 2024
lrosenfeldt
reviewed
Aug 13, 2024
| @@ -10,7 +10,7 @@ describe('ServerMetaInfo', () => { | |||
| test('initializes with correct values', () => { | |||
| const serverMetaInfo = new ServerMetaInfo(); | |||
| expect(serverMetaInfo.platformIdentifier).toBe(`${os.platform()}, node version is: ${process.version}`); | |||
| expect(serverMetaInfo.sdkIdentifier).toBe('NodeServerSDK/v0.0.2'); | |||
| expect(serverMetaInfo.sdkIdentifier).toBe('NodeServerSDK/v0.0.3'); | |||
There was a problem hiding this comment.
Als improvement können wir die Version auch aus der package.json laden, heißt aber auch, wenn es Probleme mit dem File-System gibt kann das failen. Allerdings könnte man das Modul dann auch nicht importen
There was a problem hiding this comment.
Hatte ich zuerst, aber dann sah der dist ordner nicht mehr geil aus, weil sich die root ebene geändert hat ^^
lrosenfeldt
reviewed
Aug 13, 2024
| sed -i '' "s/NodeServerSDK\/v[0-9]*\.[0-9]*\.[0-9]*/NodeServerSDK\/v$NEW_VERSION/g" ${SERVER_META_INFO_PATH} | ||
| sed -i '' "s/NodeServerSDK\/v[0-9]*\.[0-9]*\.[0-9]*/NodeServerSDK\/v$NEW_VERSION/g" ${SERVER_META_INFO_TEST_PATH} | ||
| sed -i '' "s/\"pcp-server-nodejs-sdk\": \"[0-9]*\.[0-9]*\.[0-9]*\"/\"pcp-server-nodejs-sdk\": \"$NEW_VERSION\"/g" ${EXAMPLE_APP_PACKAGE_JSON_PATH} |
There was a problem hiding this comment.
Cool, dass das hier nur mit sed. jq wäre zwar minimal safer, allerdings ist es so portabel, da sed POSIX standard ist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.