[WIP] Use Runge-Kutta-Fehlberg 7(8) integrator in SphericalDiffuse #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertodr
force-pushed
the
runge_kutta_fehlberg78
branch
2 times, most recently
from
52336af to
a245bf0
Compare
Generated by 🚫 Danger |
We also check if we are either end of the sorted array of input parameters, so that we don't fall off of it when interpolating.
robertodr
force-pushed
the
runge_kutta_fehlberg78
branch
from
9cc6e15 to
e542b49
Compare
Runge-Kutta-Fehlberg 7(8) replaces the Bulirsch-Stoer integrator. RKF78 is non-adaptive and is cheaper than BS. It is possible to use more spherical harmonics in the expansion of the Green's function radial part.
robertodr
force-pushed
the
runge_kutta_fehlberg78
branch
from
e542b49 to
191ef67
Compare
|
Seems to work fine so far (Travis complains because of some Boost headers) I think I'll bring this one a step further and introduce a simpler implementation of RKF-78 and the Legendre polynomials. We can then expunge Boost.Math. |
|
Nice! |
7 tasks
|
I think this is now obsolete because #109 is a branch which originally started from this one. |
|
Superseded by #109. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at replacing the Bulirsch-Stoer adaptive integrator with the non-adaptive Runge-Kutta-Fehlberg 7(8) in the calculation of the radial part of the spherical diffuse Green's function.
See also here
Motivation and Context
The non-adaptive integrator affords faster solution of the radial differential equation, thus allowing the use of more spherical harmonics in the expansion of the radial part.
The issues I noticed in the initial implementation, i.e. that non-adaptive integrators were not robust enough with respect to small widths of the interface, was due to a buggy implementation of the
splineInterpolationfunction. This has now been fixed, based on work we did with @ilfreddy.Todos
splineInterpolation.green_spherical_diffusetestTypes of changes
Questions
Status