Release v0.2.5 #233
Merged
Release v0.2.5 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no easy way to change figure sizes when using high-level visualization functions such as `plot_problem`. Generally, I'd prefer controlling plotting through matplotlib's `rcParams`, but this change provides at least some backwards-compatible means of changing figure sizes at a higher level by, e.g. `petab.visualize.plotting.DEFAULT_FIGSIZE = (8, 4)`.
It doesn't seem to be quite clear if the `nominalValue` column needs to be present if all parameters are estimated. However, since it's allowed to leave `nominalValue` empty, which is treated as NaN, it seems to make sense to treat a missing `nominalValue` column as all-NaN. See also ICB-DCM/pyPESTO#1104
Fixes #224 and a bunch of other pandas 2.1.0 FutureWarnings.
Relevant changes are all in .pre-commit-config.yaml, the rest is auto-formatting by isort/black
…ce (#228) Fixes a bug in petab.visualize.data_overview.create_report which fails if there is no preequilibrationConditionId column in the measurements table.
Because we treat warnings as errors, not ignoring this deprecation warning effectively breaks the pycharm debug console for pytest tests.
Allow passing a list of parameter IDs to startpoint sampling for subsetting/reordering parameters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 76.24% 76.28% +0.03%
==========================================
Files 34 34
Lines 3183 3188 +5
Branches 773 774 +1
==========================================
+ Hits 2427 2432 +5
+ Misses 555 554 -1
- Partials 201 202 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Daniel Weindl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.