Yet More Tests

[lishaduck]

Description

This PR tries to unnuke code coverage.

---

Type of Change

• 🧪 Test

Checklist

• Read the Contributing Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Fill out this template.
• Log your hours.
• Check that commits follow the Angular commit convention, more or less.
• Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

• CI

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.57%. Comparing base (23cb376) to head (ab13a6c).
Report is 13 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (23cb376) and HEAD (ab13a6c). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (23cb376)	HEAD (ab13a6c)
	2	1

see 21 files with indirect coverage changes

[lishaduck]

@MattsAttack, I got this working! Just going through and updating old tests to the new style, then I'll merge it.

[MattsAttack]

Yay! Good job! Are you going to merge fancy posts too then? I was thinking about working on images but I'll wait if you're going to merge

[lishaduck]

Yay! Good job!

Thanks! I got them all working independently, but they crash when they run together. Not sure why.

Are you going to merge fancy posts too then?

They're some other failures then. I was planning on rebasing it, fixing what's trivial, and then handing it off to you to get green.

I was thinking about working on images but I'll wait if you're going to merge

Please, make a new PR. It's too big as it is, it'll be impossible to review. You can branch off the fancy-posts branch after the rebase.

[MattsAttack]

Please, make a new PR. It's too big as it is, it'll be impossible to review. You can branch off the fancy-posts branch after the rebase.

Yeah, it's gotten a little out of control.

[lishaduck]

Please, make a new PR. It's too big as it is, it'll be impossible to review. You can branch off the fancy-posts branch after the rebase.

Yeah, it's gotten a little out of control.

And xcode got an update pushed, so my computer is busted. Oh well...

[lishaduck]

Rebased this on main, while will definitely paint this red. #68 should fix that, after which we can rebase #39 and get that merged into the trunk. Then... I'll get back to this, and @MattsAttack work on getting images fixed.

[MattsAttack]

I haven't done much image work yet. I've only started on client side uploading