Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and install CMake targets #337

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Export and install CMake targets #337

merged 1 commit into from
Dec 7, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 24, 2024

Description

libcbor already installed a cmake config file but it didn't provide linking information. This PR adds canonical export of the library, offering all usage properties via the imported target libcbor::libcbor.

  find_package(libcbor CONFIG REQUIRED)
  target_link_libraries(main PRIVATE libcbor::libcbor)

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG (example)
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 24, 2024

A variant of this change is in microsoft/vcpkg#42341. There, the CMake config is consumed by libfido2.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5369727) to head (04c852c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1662      1662           
=========================================
  Hits          1662      1662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PJK
Copy link
Owner

PJK commented Dec 7, 2024

Thank you!

@PJK PJK merged commit 34cf74b into PJK:master Dec 7, 2024
18 checks passed
@dg0yt dg0yt deleted the cmake branch December 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants