Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanger data and docker images for cell line and cptac data #61

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

sgosline
Copy link
Member

This is a big one, so @jjacobson95 can you please review before merging?

@sgosline sgosline requested a review from jjacobson95 December 12, 2023 00:05
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change dtype "somatic_mutation" to "mutations". This will make it write to cptac_mutations.csv as specified by the schema.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the samples file generation out to getCPTACSamples.py.
This will allow for the docker.cptac to be run twice, once for samples generation and once for data generation.

Also I think we should name the docker files as "dockerfile.dataname" instead of docker.dataname. I can also make these changes when I merge my branch in after this though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these changes are made, this PR should be ready to merge. Afterwhich, I'll merge my in progress branches (package_dev branch and builder_branch) to main - just to get everything up to date.

@sgosline
Copy link
Member Author

I think i got all the changes covered....

@sgosline
Copy link
Member Author

closes #59
closes #52

@sgosline sgosline merged commit 037a163 into main Dec 15, 2023
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 23, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 26, 2024
Sanger data and docker images for cell line and cptac data
sgosline added a commit that referenced this pull request Sep 26, 2024
Sanger data and docker images for cell line and cptac data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants