-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanger data and docker images for cell line and cptac data #61
Conversation
also adding new samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change dtype "somatic_mutation" to "mutations". This will make it write to cptac_mutations.csv as specified by the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split the samples file generation out to getCPTACSamples.py.
This will allow for the docker.cptac to be run twice, once for samples generation and once for data generation.
Also I think we should name the docker files as "dockerfile.dataname" instead of docker.dataname. I can also make these changes when I merge my branch in after this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once these changes are made, this PR should be ready to merge. Afterwhich, I'll merge my in progress branches (package_dev branch and builder_branch) to main - just to get everything up to date.
not sure what happened
I think i got all the changes covered.... |
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
Sanger data and docker images for cell line and cptac data
This is a big one, so @jjacobson95 can you please review before merging?