Remove type attribute

PRX · Feb 4, 2025 · 5c2d4f7 · 5c2d4f7
1 parent 212f7e1
commit 5c2d4f7
Show file tree

Hide file tree

Showing 11 changed files with 5 additions and 19 deletions.
diff --git a/app/controllers/podcast_engagement_controller.rb b/app/controllers/podcast_engagement_controller.rb
@@ -38,7 +38,7 @@ def podcast_engagement_params
       :lock_version,
       :donation_url,
       :payment_pointer,
-      subscribe_links_attributes: %i[id enabled external_id platform type]
+      subscribe_links_attributes: %i[id enabled external_id platform]
     )
   end
 end
diff --git a/app/javascript/controllers/subscribe_links_controller.js b/app/javascript/controllers/subscribe_links_controller.js
@@ -5,12 +5,12 @@ export default class extends Controller {
 
   addLink(event) {
     const now = new Date().getTime()
-    const platform = event.target.value
+    const platform = event.target.dataset.platform
 
     const template = this.templateTargets.filter((target) => {
       return target.dataset.platform === platform
     })
-    const html = template[0].innerHTML.replaceAll("NEW_RECORD", now).replaceAll("NEW_PLATFORM", platform)
+    const html = template[0].innerHTML.replaceAll("NEW_RECORD", now)
     this.templateTarget.insertAdjacentHTML("beforeBegin", html)
   }
 }
diff --git a/app/models/subscribe_links/apple.rb b/app/models/subscribe_links/apple.rb
diff --git a/app/models/subscribe_links/overcast.rb b/app/models/subscribe_links/overcast.rb
diff --git a/app/models/subscribe_links/pocket_casts.rb b/app/models/subscribe_links/pocket_casts.rb
diff --git a/app/models/subscribe_links/spotify.rb b/app/models/subscribe_links/spotify.rb
diff --git a/app/models/subscribe_links/youtube.rb b/app/models/subscribe_links/youtube.rb
diff --git a/app/views/podcast_engagement/_form_subscribe_link.html.erb b/app/views/podcast_engagement/_form_subscribe_link.html.erb
@@ -16,5 +16,5 @@
     </div>
   </div>
 </div>
-<%= form.hidden_field :type %>
+
 <%= form.hidden_field :platform %>
diff --git a/app/views/podcast_engagement/_form_subscribe_links.html.erb b/app/views/podcast_engagement/_form_subscribe_links.html.erb
@@ -33,7 +33,7 @@
           <ul class="dropdown-menu">
             <% SubscribeLink::PLATFORMS.each do |p| %>
               <li>
-                <button class="dropdown-item" type="button" data-action="subscribe-links#addLink" value="<%= p %>">
+                <button class="dropdown-item" type="button" data-action="subscribe-links#addLink" data-platform="<%= p %>">
                   <%= t(".labels.#{p}") %>
                 </button>
               </li>

diff --git a/db/migrate/20241220170043_create_subscribe_links.rb b/db/migrate/20241220170043_create_subscribe_links.rb
@@ -6,7 +6,6 @@ def change
       t.boolean :enabled
       t.integer :external_id
       t.string :platform
-      t.string :type
     end
   end
 end
diff --git a/db/schema.rb b/db/schema.rb
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,5 +16,5 @@ @@
         </div>
       </div>
     </div>
-    <%= form.hidden_field :type %>
     <%= form.hidden_field :platform %>