Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

work: fixed options not showing up on the bottom screen + db issues #83

work: fixed options not showing up on the bottom screen + db issues

work: fixed options not showing up on the bottom screen + db issues #83

Triggered via push October 16, 2023 16:29
Status Success
Total duration 1m 12s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

clippy.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
`to_string` applied to a type that implements `Display` in `format!` args: src/display/mod.rs#L125
warning: `to_string` applied to a type that implements `Display` in `format!` args --> src/display/mod.rs:125:73 | 125 | format!("{}{}", DISPLAY_OPT_MAX_REDIRECTS, max_redirects.to_string()) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/display/mod.rs#L112
warning: `to_string` applied to a type that implements `Display` in `format!` args --> src/display/mod.rs:112:59 | 112 | format!("{}{}", DISPLAY_OPT_MAX_REC, level.to_string()) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default
the following explicit lifetimes could be elided: 'a: src/screens/input/url.rs#L39
warning: the following explicit lifetimes could be elided: 'a --> src/screens/input/url.rs:39:24 | 39 | fn create_screen_title<'a>(title_str: &'a str) -> Paragraph<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 39 - fn create_screen_title<'a>(title_str: &'a str) -> Paragraph<'a> { 39 + fn create_screen_title(title_str: &str) -> Paragraph<'_> { |
the following explicit lifetimes could be elided: 'a: src/screens/input/test.rs#L57
warning: the following explicit lifetimes could be elided: 'a --> src/screens/input/test.rs:57:24 | 57 | fn create_screen_title<'a>(title_str: &'a str) -> Paragraph<'a> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 57 - fn create_screen_title<'a>(title_str: &'a str) -> Paragraph<'a> { 57 + fn create_screen_title(title_str: &str) -> Paragraph<'_> { |
very complex type used. Consider factoring parts into `type` definitions: src/screens/input/test.rs#L12
warning: very complex type used. Consider factoring parts into `type` definitions --> src/screens/input/test.rs:12:59 | 12 | fn create_layout<B: Backend>(frame: &mut Frame<'_, B>) -> (Rc<[Rect]>, Rc<[Rect]>, Rc<[Rect]>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
module has the same name as its containing module: src/screens/input/mod.rs#L1
warning: module has the same name as its containing module --> src/screens/input/mod.rs:1:1 | 1 | pub mod input; | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: src/screens/method.rs#L13
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/screens/method.rs:13:5 | 13 | / match app.selected { 14 | | Some(num) => { 15 | | app.command 16 | | .as_mut() ... | 21 | | _ => {} 22 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try this | 13 ~ if let Some(num) = app.selected { 14 + app.command 15 + .as_mut() 16 + .unwrap() 17 + .set_method(String::from(METHOD_MENU_OPTIONS[num])); // safe index 18 + app.goto_screen(Screen::RequestMenu(String::from(METHOD_MENU_OPTIONS[num]))); 19 + } |
function `setup` is never used: src/request/wget.rs#L212
warning: function `setup` is never used --> src/request/wget.rs:212:8 | 212 | fn setup() -> ServerGuard { | ^^^^^ | = note: `#[warn(dead_code)]` on by default
unused import: `super::*`: src/request/wget.rs#L209
warning: unused import: `super::*` --> src/request/wget.rs:209:9 | 209 | use super::*; | ^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/