This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
feat: fix saved keys + saved commands menus. tests should pass #86
PThorpe92
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
8 warnings
|
`to_string` applied to a type that implements `Display` in `format!` args:
src/display/mod.rs#L125
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/display/mod.rs:125:73
|
125 | format!("{}{}", DISPLAY_OPT_MAX_REDIRECTS, max_redirects.to_string())
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
src/display/mod.rs#L112
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/display/mod.rs:112:59
|
112 | format!("{}{}", DISPLAY_OPT_MAX_REC, level.to_string())
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
module has the same name as its containing module:
src/screens/input/mod.rs#L1
warning: module has the same name as its containing module
--> src/screens/input/mod.rs:1:1
|
1 | pub mod input;
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/screens/method.rs#L13
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/screens/method.rs:13:5
|
13 | / match app.selected {
14 | | Some(num) => {
15 | | app.command
16 | | .as_mut()
... |
21 | | _ => {}
22 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try this
|
13 ~ if let Some(num) = app.selected {
14 + app.command
15 + .as_mut()
16 + .unwrap()
17 + .set_method(String::from(METHOD_MENU_OPTIONS[num])); // safe index
18 + app.goto_screen(Screen::RequestMenu(String::from(METHOD_MENU_OPTIONS[num])));
19 + }
|
|
|
function `setup` is never used:
src/request/wget.rs#L217
warning: function `setup` is never used
--> src/request/wget.rs:217:8
|
217 | fn setup() -> ServerGuard {
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `super::*`:
src/request/wget.rs#L214
warning: unused import: `super::*`
--> src/request/wget.rs:214:9
|
214 | use super::*;
| ^^^^^^^^
|
|
unused import: `default`:
src/lib.rs#L2
warning: unused import: `default`
--> src/lib.rs:2:11
|
2 | use std::{default, fmt::Display};
| ^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|