-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: credentials config #707
base: main
Are you sure you want to change the base?
Conversation
Ping @PacoVK |
Thanks for your contribution! While i see this may be usefull this PR needs more than just add the ENVs.
TL;DR; i will accept this feature, but it must work with the real API prior i can accept this PR :) |
Hi @PacoVK, |
Thanks again! As soon as I find time I test it again. So far the parameter caused bad request even though it was set to false |
After reviewing i still see some work to do here to make it work.
I really appreciate the changes you make. Please also test them in advance to verify the changes you made do not break anything that exists :) |
Initially you said
Now you say:
...which is normal. If the endpoint definition is optional then the library uses the aws one by default. |
Sorry if it was unclear, what i essentially meant was that the whole endpoint resolver must be optional. If i run your code, with AWS credentials set, then there is an error about the config, and it only works if the whole endpoint resolver has been removed. That said we could make the whole EP resolver optional and thus also keep the localstack url, in case there has been no SQS_ACCESS_KEY_ID set. Is that understandable? You can easily test your code by just connecting SQS Admin to a real AWS account. There are still other parts as i mentioned that need further changes in order to work |
With this PR I would like to introduce credentials configurations through environment variables