This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Improve minifyability #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgwModal now gives problems when minifying in ASP.NET Bundles. This is because ASP.NET bundles also change the function variable names. However in 1 function you use $compile, which is detected by AngularJS by name. Because AngularJS detects the $compile service by name, the code stops working when the minifyer changes the variable name to, let's say 'r'. AngularJS adds the possibility to name the parameter using a string (which the minifyer leaves unharmed). So applying this change allows the code to be minified correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PgwModal now gives problems when minifying in ASP.NET Bundles. This is because ASP.NET bundles also change the function variable names.
However in 1 function you use $compile, which is detected by AngularJS by name. Because AngularJS detects the $compile service by name, the code stops working when the minifyer changes the variable name to, let's say 'r'.
AngularJS adds the possibility to name the parameter using a string (which the minifyer leaves unharmed).
So applying this change allows the code to be minified correctly.