Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch to schema component to workaround broken discriminators #788

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

sserrata
Copy link
Member

Description

Patched Schema component to work around malformed discriminator schemas in some CSPM APIs. Will continue working with CSPM team to cleanup/address OpenAPI specs and work on adding additional error handling to OpenAPI docs plugin.

@sserrata sserrata added the bug Something isn't working label Dec 11, 2024
@sserrata sserrata self-assigned this Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Visit the preview URL for this PR (updated for commit a27c4db):

https://pan-dev-f1b58--pr788-6jzg67xj.web.app

(expires Fri, 10 Jan 2025 21:26:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9359a9fa100d5fdb082f75280473a90b1f96eb51

@sserrata sserrata requested a review from a team as a code owner December 11, 2024 19:05
Copy link
Contributor

@jrdevore jrdevore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified troublesome pages and categories with discriminator use in openapi-specs/cspm/.

  • MSSP and Action Plan pages look good as well

@blindaa121 blindaa121 merged commit cbd2014 into master Dec 11, 2024
6 checks passed
@blindaa121 blindaa121 deleted the discriminator-patch branch December 11, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants