Skip to content

Commit

Permalink
move TODO into commit message
Browse files Browse the repository at this point in the history
                        # TODO: looks like there was maybe a bug here in the
                        # original code: was looking at joinable, not at
                        # future, so always going down the render-as-future path?
                        # should be easy to test...
  • Loading branch information
benclifford committed Jan 13, 2025
1 parent 3b9c179 commit 43196e0
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions parsl/dataflow/dflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,6 @@ def handle_join_update(self, task_record: TaskRecord, inner_app_future: Optional
for future in joinable:
je = future.exception()
if je is not None:
# TODO: looks like there was maybe a bug here in the
# original code: was looking at joinable, not at
# future, so always going down the render-as-future path?
# should be easy to test...
tid = self.render_future_description(future)
exceptions_tids.append((je, tid))
else:
Expand Down

0 comments on commit 43196e0

Please sign in to comment.