-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cctools in CI #2912
Upgrade cctools in CI #2912
Conversation
The previous version, 7.5.4, is from May 2023, and some development, especially in Task Vine, has happened since then.
This upgrade is breaking in CI with a missing @dthain @tphung3 Maybe I should make CI do wq and taskvine tests via a
|
Yes, Conda is the preferred way to install cctools with its dependencies: When we run nightly integration tests, we do (basically) That said, a full Conda install can be slow, as you know. For the sake of testing WQ integration, you might consider just pip install the missing python bits cloudpickle, packaging, and conda-pack. |
The latest conda setup + build from cctools takes around 3-4 mins https://github.com/cooperative-computing-lab/cctools/actions/runs/6536439492/job/17748174749 (we don't need build by the way) so it's not impossible to use Alternatively, as @dthain suggests we can bandage the missing dependencies by adding |
On another thought, the conda setup time is varied probably because it has to solve for the right versions of dependencies. Since we fixed the version of cctools (e.g., 7.7.0) I think we can remove this solving time by having a yml file describing exact versions of cctools dependencies, then whenever we change the cctools version we change this yml file too. |
close in favor of #2922 |
The previous version, 7.5.4, is from May 2023, and some development, especially in Task Vine, has happened since then.
Type of change