Make pytest fail when tasks are running after a test #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
approved these changes
Nov 1, 2023
When pressing ctrl-c in pytest, prior to this PR, it would hang as wait_for_task_completion would be called in the unwinding of the fixture stack. However, because ctrl-c was pressed, tasks wouldn't be expected to all complete. This PR changes that to assert that all tasks are completed, rather than *waiting* for all tasks to complete. A non-finished task now gives a test error - which is arguably better anyway because it more aggressively flushes out tests that do not perform a complete shutdown. This means that pressing ctrl-C in a pytest leads to an assertion error; when previously it led to a hang. One recently introduced test is fixed to This is part of safe-shutdown work.
khk-globus
force-pushed
the
benc-tests-no-running-tasks
branch
from
81be8e5 to
488aa37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing ctrl-c in pytest, prior to this PR, it would hang as wait_for_task_completion would be called in the unwinding of the fixture stack. However, because ctrl-c was pressed, tasks wouldn't be expected to all complete.
This PR changes that to assert that all tasks are completed, rather than waiting for all tasks to complete.
A non-finished task now gives a test error - which is arguably better anyway because it more aggressively flushes out tests that do not perform a complete shutdown.
This means that pressing ctrl-C in a pytest leads to an assertion error; when previously it led to a hang.
One recently introduced test is fixed to conform to this new requirement.
This is part of safe-shutdown work.
Type of change