debugging a desc-branch test hang in config local tests #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code around block ID allocation was a bit fuzzy and it looks like it could sometimes allocate the same block ID several times in the presence of failure. This is at least causing confusion in debugging frequent hangs in CI. A second ID allocated was used when a block ID had not already been allocated, for simulating failures. This ID allocation code is changed in this PR to use the same sequence counter.
The before message referred to manager; the after message referred to worker. This patch makes them the same - using manager
…tigating in serialization vs monitoring
… WQ coprocesses for monitoring test as that is the intended usage mode, and the non-coprocess path seems to have some problems
…fter splitting monitoring and visualization dependencies
…stem mode on WQ, as I didn't intend to switch it away from that in recent push to desc branch
benclifford
force-pushed
the
benc-tmp-hang-bisect
branch
2 times, most recently
from
2a1efc1 to
be4371d
Compare
add cctools to dependency
benclifford
force-pushed
the
benc-tmp-hang-bisect
branch
from
be4371d to
001e2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.