Refactor 4 different renderings of task description #3743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, there were 4 variant ways to render a future (which is usually but not always a Parsl task) as a text string:
rendered task ID if there was a task_record, and the
future is from the same DFK as is rendering the code
(so that a task number from a different DFK is not
rendered, in the corner case of a task from one DFK
being used as a dependency for a task in another DFK)
otherwise, renders the repr of the future
This PR makes a single render method. It is a member of the DFK, because rendering is done in the context of the DFK: two parsl task AppFutures will be rendered differently if they are from this DFK or a different DFK.
This PR implements render_future_description which tries to combine all of the above:
DFK, render the task ID
Changed Behaviour
human readable descriptions of dependencies/join inner futures will be changed
Fixes
Fixes # (issue)
Type of change
Choose which options apply, and delete the ones which do not apply.