-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different preview modes: full, count, none #40
Open
brewingcode
wants to merge
18
commits into
PaulJuliusMartinez:main
Choose a base branch
from
brewingcode:optional-container-counts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+228
−15
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fe48f5a
Copy generate_container_preview as generate_container_count
brewingcode 6eedd02
Fix `cargo build` error
brewingcode 8c82925
Add `JsonViewer.preview`, and have `fill_in_container_preview` read it
brewingcode 1e6dbc1
Reduce complexity of `generate_container_count`
brewingcode f7e2c0b
Remove `preview` from `JsonViewer::new`, set it elsewhere
brewingcode a9a4225
Add test for `generate_container_count`
brewingcode 8ab2644
Add "none" as an option to `preview`
brewingcode c1bfd33
Merge remote-tracking branch 'origin/master' into optional-container-…
brewingcode 8ad349d
Update jless.help and usage.html
brewingcode 6a41936
Fix `none` preview mode
brewingcode 2ee1eb6
Fix .len() vs .chars().count()
brewingcode 6f71ce0
Add "items" to disambiguate arrays
brewingcode 26a6059
Disable Preview::None in Mode::Line
brewingcode 452fafd
Merge remote-tracking branch 'origin/master' into optional-container-…
brewingcode 41079e9
Fix lint errors and warnings
brewingcode edeaf29
Merge remote-tracking branch 'origin/master' into optional-container-…
brewingcode 4bbcff7
Merge remote-tracking branch 'origin/main' into optional-container-co…
brewingcode 73ae72a
Fix lint and trivial code style
brewingcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the linter is being overzealous here, and in the rest of the
test_
functions in this commit. It's way harder to read thisvec![...]
on a single line. They were on their own lines with specific spacing to make it easier for humans to read.