-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(player): enable audio offloading #2413
base: main
Are you sure you want to change the base?
Conversation
Iirc it does not work with skip silence and speed adjustments |
Sorry for hijacking this, but would it be possible to have skipsilence implemented the way NewPipe does it? What I mean is that they don't just cut which is quite jarring but ramp-up instead. AFAIK they're using ExoPlayer too |
Hmm, that would be a bummer? I thought |
Ooh you are right! I did not check the pr properly, my bad. I think these changes are dangerous nevertheless. Wdyt about a setting: Experimental audio Player |
I'm generally not a fan of settings for various reasons (IMHO they're often bad for both the user and the maintainer). Maybe it could be added as an experimental setting first, and after some time, if there are no problems, move to it being enabled by default? |
Yep that was my idea |
I've been trying to implement the settings, but due to me being inexperienced/not understanding the architecture/not being an android dev, I've had some trouble getting it to work. Would appreciate some help/pointers, otherwise I will take another look when I have some more time. |
Enables the AudioOffloading feature of the Exoplayer, which reduces power consumption and hopefully helps with issues like #2216.
I have not had time to fully test this yet.