Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically start sleep timer on time schedule #2673

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

happy-turtle
Copy link

@happy-turtle happy-turtle commented Jan 14, 2025

Referring to this feature request. I implemented a new setting for the sleep timer where one can set a start and an end time. If the current local time is in-between the two, the sleep timer will start automatically on playback. I am using this feature on my own device already, but of course I'm open for any suggestions on UI changes or similar.
sleep timer screen with sleep timer schedule turned off sleep timer screen with sleep timer schedule turned on open time picker dialog

@PaulWoitaschek
Copy link
Owner

Nice!

I think the logic would make more sense if it was a little different:

  • Add that as a setting to the settings menu
  • Two rows entries, one for the checkbox and dscription, and one for setting the timing
  • When the checkbox is is checked, the timing entry gets greyed out

Then it's clearer and more consistent that this is a global setting, affecting all books.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants