chinnk2/pyobd.pi #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot compare methods and strings.
ELM327.status is a function, not an attribute
I've noticed many invalid returns from can of size 19 when padded with the additional 5 zeros. This crashes the watcher thread. This will handle them as unhexlify dumps
Handle odd sized returns on CAN
Add a common issue section and document the Bluetooth issue. Signed-off-by: Alistair Francis <[email protected]>
README: Add a common issue section
Fix send delay for bluetooth/Raspberry Pi
Patch invalid protocol error message.
This adds support for the Mode 9 PIDS, including VIN and CVN. This is baed on the original work by Paul Mundt (#151). This patch includes adding a few test cases for the new decoders. Signed-off-by: Alistair Francis <[email protected]>
Add support for Mode 9 PIDS
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
travis: Update the Python versions
#### Issues Addressed When using OBD over legacy protocols like K-line the message is rejected because the ecu id is undefined even if the data is retrieved correctly. #### Summary of changes Add the ENGINE ID and TRANSMISSION ID to the list of ecu map at object creation time to have it available when receiving the message. #### Summary of testing Data is retrieved correctly on K-Line. Car used VW Lupo GTI Data is retrieved correctly on CAN cars. Car used Ford Focus. Signed-off-by: Catalin Ghenea <[email protected]>
Increase "0100" query (PIDS_A) timeout to support inexpensive/slow OBDII adapters. This patch fixes the case in which "SEARCHING" is not shown after "0100", due to slow response of cheap devices. ``` [obd.elm327] write: '0100\r' [obd.elm327] read: b'SEARCHING...\r... ``` It should also fix the case in which the debug mode needs to be active: in fact the debug logs might slow down the query timeout enough to be able to catch the query answer. Reference #205 Reference #200 Reference #187
#### Issues addressed Can't auto detect protocol on BT connection even if the elm devices detects the protocol successfully. Add delay after erasing stored protocols so the adapter can read the discover command #### Summary of testing Tested on an Mazda MX5. The protocol can be detected successfully on each run. Tested for about 10 times in a row. Signed-off-by: Catalin Ghenea <[email protected]>
Right now __read() will stop reading at "OK" even if a ">" is still coming. This can cause the ">" to be seen as the response to the next command, which confuses the initialization sequence, since the initialization sequence expects a very specific set of responses to its commands. This changes __read() so that by default it only treats ">" as the response terminator. When we issue the "ATLP" command to enter low-power mode, we will use "OK" as the response terminator instead, since that's the only time we don't expect to see a prompt. This should fix #226 and should also fix #227.
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Also fixed some of the doc headers for more modern versions of mkdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.