-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable action workflows #3285
Reusable action workflows #3285
Conversation
Ahh, finally breaking down our CI into subparts, Will get to review this week, but okay if @robkooper finishes it before me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no major changes required as I see that all the test run in the workflows on this PR, we need to make certain workflows as required, but that needs to be done by you guys (People with access to settings).
I just doubt about ci-weekly
but let's merge this and see if that runs okay,
Thanks for the effort to decouple our CI @infotroph , things will look a lot more sorted now!
From the logs, the docker failure seems unrelated, can you merge main @infotroph , lets see if the docker passes now |
Edit: I see what you mean now -- turns out GitHub labels them differently even when we don't change the names. Yes, I'll handle this on merge. |
Description
Avoids repeating ourselves by defining the test/check/sipnet workflows once and calling them from both the on-push and the weekly Actions.
Motivation and Context
Review Time Estimate
Types of changes
Checklist: