Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connectivity field names compatible with MATLAB #166

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 19, 2024

Closes #164.

Changes proposed in this pull request

  • Add "atlas_" prefix to field names in connectivity MAT files. This will ensure that no fields start with a number (e.g., an atlas name that starts with a number, like 4S*), which is an issue for MATLAB.
  • Replace dashes with underscores in measure names. This should change small-worldness to small_worldness.

Documentation to review

@tsalo tsalo added the bug Something isn't working label Nov 19, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 19, 2024

We should probably document the connectivity files based on @valeriejill's pre-split QSIPrep PR: PennLINC/qsiprep#689

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.94%. Comparing base (64be9d6) to head (e5b3420).

Files with missing lines Patch % Lines
qsirecon/interfaces/dsi_studio.py 0.00% 4 Missing ⚠️
qsirecon/interfaces/mrtrix.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   33.94%   33.94%   -0.01%     
==========================================
  Files          57       57              
  Lines        7193     7195       +2     
  Branches      983      983              
==========================================
  Hits         2442     2442              
- Misses       4653     4655       +2     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tsalo tsalo merged commit 46b699d into main Nov 19, 2024
24 checks passed
@tsalo tsalo deleted the fix-connectivity-fields branch November 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid field names in connectivity *.MAT file from dsi_studio_gqi
2 participants