use github api instead of raw file to download fingerprint #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a small change in the runner/download.go for the functions
These two functions require saving the fingerprint json from https://github.com/EdOverflow/can-i-take-over-xyz/blob/master/fingerprints.json which uses the raw downloading from GitHub but the raw file download is returning an HTTP timeout error, so I use the API download for my personal use and it has been working. It gets the encoded bas64 content then I decode it and save it as the normal save.
I did not touch any other file or function so this should work fine, additional tests may also be a good option.