Merge pull request #9 from PhantPHP/Fix-CollectionPaginatedTest

Fix collection paginated test
PhantPHP · Sep 8, 2022 · d495093 · d495093
2 parents 2c930f5 + ceda150
commit d495093
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/component/Abstract/CollectionPaginated.php b/component/Abstract/CollectionPaginated.php
@@ -3,6 +3,8 @@
 
 namespace Phant\DataStructure\Abstract;
 
+use Phant\Error\NotCompliant;
+
 abstract class CollectionPaginated extends Collection
 {
 	private ?int $itemPage;
@@ -86,6 +88,16 @@ public function serialize(): ?array
 
 	public static function unserialize(array $serialized): self
 	{
+		if (!( array_key_exists('pagination', $serialized)
+			&& array_key_exists('page', $serialized['pagination'])
+			&& array_key_exists('current', $serialized['pagination']['page'])
+			&& array_key_exists('item', $serialized['pagination'])
+			&& array_key_exists('by_page', $serialized['pagination']['item'])
+			&& array_key_exists('total', $serialized['pagination']['item'])
+		)) {
+			throw new NotCompliant();
+		}
+
 		$collection = new static(
 			$serialized['pagination']['page']['current'],
 			$serialized['pagination']['item']['by_page'],

diff --git a/test/Abstract/CollectionPaginatedTest.php b/test/Abstract/CollectionPaginatedTest.php
@@ -8,6 +8,8 @@
 	Value,
 };
 
+use Phant\Error\NotCompliant;
+
 final class CollectionPaginatedTest extends \PHPUnit\Framework\TestCase
 {
 	public function testInterface(): void
@@ -83,4 +85,11 @@ public function testInterface(): void
 
 		$this->assertEquals($collection, $unserialized);
 	}
+
+	public function testUnserializeNotCompliant(): void
+	{
+		$this->expectException(NotCompliant::class);
+
+		CollectionPaginated::unserialize([[]]);
+	}
 }