fix(saleheaderbanner): L3-4298 support translations for the countdown component #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-4298
Screenshots
Summary
The Countdown timer related fields in the SaleHeaderBanner were not translatable, this adds that capability
Change List (describe the changes made to the files)
Key changes include:
Enhancements to
SaleHeaderBanner
component:countdownTimerLabel
andcountdownFormatDuration
properties toSaleHeaderBannerProps
to allow customization of the countdown timer label and duration format.SaleHeaderBanner
component to use the new countdown properties when rendering the countdown timer. [1] [2]Acceptance Test (how to verify the PR)
Regression Test
Evidence of testing
Things to look for during review
feat(scope): ...
if aminor
release should be triggered.phillips
class prefix are using the prefix variabledata-testid
attribute.New Components
index.ts
filecomponentStyles.scss
file.