-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): L3-4707 Remove Focus Border From Tabs on Click #484
Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the keyboard navigation here isn't quite right. Hitting tab again should not change to the next
<Key presses>
Tab : When focus moves to the tabs-widget, the active tab-element gets focus.
When the focus is in the tab-element, the focus moves to the next focusable item (so, not to the next tab).
This can mean either item in the active tab panel or first thing outside the widget.
Left Arrow: When the focus is on the active tab-element, the focus moves to the next tab on the list. If on the last tab, focus moves to the first tab. If tabs are automatically activated, activates the focused tab.
Right Arrow: When the focus is on the active tab-element, the focus moves to the previous tab on the list. If on the first item, moves focus to the last tab. If tabs are automatically activated, activates the focused tab.
https://dev.to/eevajonnapanula/keyboard-accessible-tabs-with-react-5ch4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This issue has been resolved in version 1.109.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Jira ticket
L3-4707
Screenshots
Summary
Fixed tabbing functionality and corrected focus styles
Change List (describe the changes made to the files)
Acceptance Test (how to verify the PR)
Things to look for during review
feat(scope): ...
if aminor
release should be triggered.phillips
class prefix are using the prefix variabledata-testid
attribute.New Components
index.ts
filecomponentStyles.scss
file.