Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): L3-4707 Remove Focus Border From Tabs on Click #484

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

adietrich3074
Copy link
Collaborator

@adietrich3074 adietrich3074 commented Jan 23, 2025

Jira ticket

L3-4707

Screenshots

Before After
ea2f0ca4-68b3-4650-bfc9-4cf56f89a6db Screenshot 2025-01-23 121134

Summary

Fixed tabbing functionality and corrected focus styles

Change List (describe the changes made to the files)

  • Adjusted padding for tab content
  • Added tabIndex to TabTrigger component

Acceptance Test (how to verify the PR)

  • Verify that outline only shows when tabbing through tabs and not on click of the tab

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 499468e
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/6797cffa02f9f00008c9d004
😎 Deploy Preview https://deploy-preview-484--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the keyboard navigation here isn't quite right. Hitting tab again should not change to the next

<Key presses>
Tab : When focus moves to the tabs-widget, the active tab-element gets focus. 
When the focus is in the tab-element, the focus moves to the next focusable item (so, not to the next tab).
 This can mean either item in the active tab panel or first thing outside the widget.
Left Arrow: When the focus is on the active tab-element, the focus moves to the next tab on the list. If on the last tab, focus moves to the first tab. If tabs are automatically activated, activates the focused tab.
Right Arrow: When the focus is on the active tab-element, the focus moves to the previous tab on the list. If on the first item, moves focus to the last tab. If tabs are automatically activated, activates the focused tab.

https://dev.to/eevajonnapanula/keyboard-accessible-tabs-with-react-5ch4

@scottdickerson scottdickerson self-requested a review January 28, 2025 15:26
Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottdickerson scottdickerson merged commit d49860f into main Jan 28, 2025
12 checks passed
@scottdickerson scottdickerson deleted the L3-4707_Remove_Focus_Border_From_Tabs branch January 28, 2025 15:27
davidicus pushed a commit that referenced this pull request Jan 28, 2025
## [1.109.1](v1.109.0...v1.109.1) (2025-01-28)

### Bug Fixes

* **bidsnapshot:** L3-4432 My Account - Lot Tile Update ([#485](#485)) ([1bbfe44](1bbfe44))
* **tabs:** L3-4707 Remove Focus Border From Tabs on Click ([#484](#484)) ([d49860f](d49860f))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.109.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants