Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bidsnapshot): L3-4432 My Account - Lot Tile Update #485

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

smarks8
Copy link
Contributor

@smarks8 smarks8 commented Jan 23, 2025

Jira ticket

L3-4432

Screenshots

Before After

|
image
|
image
|

Summary

  • Minor styling adjustments to the countdown section in BidSnapshot, so the countdown doesn't overlap with other object tiles or spacers in a grid layout

Change List (describe the changes made to the files)

  • css changes in bidsnapshot.scss
  • passing a flag in bidsnapshot.tsx

Acceptance Test (how to verify the PR)

  • See that BidSnapshot and ObjectTile components look as expected
  • Verify that tiles look okay in grid layouts (auction page, in client portal - bids page and favorites page)

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 5535e19
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/67928ae5e073900008689e46
😎 Deploy Preview https://deploy-preview-485--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottdickerson scottdickerson merged commit 1bbfe44 into main Jan 28, 2025
14 checks passed
@scottdickerson scottdickerson deleted the L3-4432-my-account-lot-tile-update branch January 28, 2025 15:28
davidicus pushed a commit that referenced this pull request Jan 28, 2025
## [1.109.1](v1.109.0...v1.109.1) (2025-01-28)

### Bug Fixes

* **bidsnapshot:** L3-4432 My Account - Lot Tile Update ([#485](#485)) ([1bbfe44](1bbfe44))
* **tabs:** L3-4707 Remove Focus Border From Tabs on Click ([#484](#484)) ([d49860f](d49860f))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.109.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants