Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(_pageContentWrapper.scss): L3-4620 added new page wrapper and tokens #496

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

constantinehuzenko
Copy link
Contributor

@constantinehuzenko constantinehuzenko commented Jan 30, 2025

L3-4620

L3-4620

Screenshots

Before bp-md After bp-md
image image
Before bp-xl After bp-xl
image image

Figma link

https://www.figma.com/deck/hqJJvOsa9XrlafXAR9aiwS/EASEL-Foundation?node-id=9-889&viewport=-28375%2C-151%2C0.7&t=uPw9sTzQupBPYert-1&scaling=min-zoom&content-scaling=fixed&page-id=0%3A1

image

Summary

Add high-level overview of the changes that were made and explanation of WHY they were made

Change List (describe the changes made to the files)

  • src/components/PageContentWrapper/_pageContentWrapper.scss: added new BP and updated spacing
  • src/scss/_vars.scss: added new tokens
  • src/design/spacing-tokens/spacing-tokens.mdx: updated documentation

Acceptance Test (how to verify the PR)

  • go to /?path=/story/components-pagecontentwrapper--playground in seldon
  • verify that page wrapper following new margins
  • verify that tokens from figma file are the same on seldon

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 6192abe
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/679bfe28d1d9bd00081affe8
😎 Deploy Preview https://deploy-preview-496--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@constantinehuzenko constantinehuzenko merged commit e438b2b into main Jan 31, 2025
18 checks passed
@constantinehuzenko constantinehuzenko deleted the L3-4620-new-maring branch January 31, 2025 22:31
davidicus pushed a commit that referenced this pull request Jan 31, 2025
# [1.110.0](v1.109.2...v1.110.0) (2025-01-31)

### Features

* **_pageContentWrapper.scss:** L3-4620 added new page wrapper and tokens ([#496](#496)) ([e438b2b](e438b2b))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.110.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants