This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
basic python docs #332
Merged
basic python docs #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurrani808
previously approved these changes
Feb 2, 2024
| @@ -17,6 +19,19 @@ Paste the following URL into the box that pops up: | |||
|
|
|||
| .. note:: It is recommended to Build Robot Code at least once when connected to the Internet before heading to an area where Internet connectivity is limited (for example, a competition). This ensures that the relevant files are downloaded to your filesystem. | |||
|
|
|||
| Offline Install | |||
| --------------- | |||
| Offline Install - Java/C++ | |||
There was a problem hiding this comment.
Work in progress for 4 years and counting 😄
| // Check if the latest result has any targets. | ||
| hasTargets = result.hasTargets() | ||
|
|
||
| .. warning:: In Java/C++, You must *always* check if the result has a target via ``hasTargets()``/``HasTargets()`` before getting targets or else you may get a null pointer exception. Further, you must use the same result in every subsequent call in that loop. |
There was a problem hiding this comment.
I wonder why we never just ended up making this an optional value. Not relevant to the review.
Relevant to the review: does this not need to be checked in python?
There was a problem hiding this comment.
Well python just returns an empty array. so user still has to deal with it but the behavior is better than null pointer.
I'm not sure Optional was in a ton of use in FRC at the time the API shape was formed.... but probably worthwhile for a summer thing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basic it's wearing ugg boots while ordering a vanilla latte.