use a new mutex wrapper API #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrygerardmoore
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
I pushed commits that should hopefully fix CI.
Regarding the priority inversion problem, should we maybe just mention this in the example or documentation so unfamiliar users are aware of the possibility? I think this PR is a good change anyway, and won't block on that
If you think adding to the documentation or examples is a good idea, I wanted to let you do that since I think you'd explain it better, but let me know if you don't have time and I can take a pass at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #25
PROS:
CONS
In practice, I don't know what is better/worse.