Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors parsing expressions #329

Open
fmrico opened this issue Oct 17, 2024 · 2 comments · May be fixed by #334
Open

Errors parsing expressions #329

fmrico opened this issue Oct 17, 2024 · 2 comments · May be fixed by #334
Assignees

Comments

@fmrico
Copy link
Contributor

fmrico commented Oct 17, 2024

Hi!!

I am getting these errors, and I would like to know if it is really an error.

getExpr: Error parsing expresion [(and (car_assembled car1))]
getExpr: Error parsing expresion [(car_assembled car1)]
getExpr: Error parsing expresion [(and (car_assembled car2))]
getExpr: Error parsing expresion [(car_assembled car2)]
getExpr: Error parsing expresion [(and (car_assembled car3))]
getExpr: Error parsing expresion [(car_assembled car3)]

https://github.com/PlanSys2/ros2_planning_system/blame/b82cc6fe5d577e481b0aa01b6b779f94d33b9ebe/plansys2_pddl_parser/src/plansys2_pddl_parser/Utils.cpp#L278

Thanks!!!

@roveri-marco
Copy link
Collaborator

@fmrico How can I reproduce the problem? Can you circulate the PDDL domain file and the problem file or the commands to reproduce them?

@Rezenders
Copy link
Contributor

I don't believe this is an actual error.

In the following code, getExpr(expr) is being called to get the expression, and it is also being used to check if expr is an expression. When it is not an expression, it prints that there was an error parsing the expression, but it is not an error. expr isn't an expression. I believe the print can be removed

std::tuple<uint8_t, int> expression_search_result = getExpr(expr);
if (std::get<0>(expression_search_result) != plansys2_msgs::msg::Node::UNKNOWN) {
if (std::get<1>(expression_search_result) < first) {
first = std::get<1>(expression_search_result);
node_type = plansys2_msgs::msg::Node::EXPRESSION;
}
}

fmrico added a commit to fmrico/ros2_planning_system that referenced this issue Nov 20, 2024
Signed-off-by: Francisco Martín Rico <[email protected]>
@fmrico fmrico linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants