Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple_bt_builder] Question about action parallelization algorithm #331

Open
Rezenders opened this issue Oct 29, 2024 · 1 comment
Open

Comments

@Rezenders
Copy link
Contributor

Why does it only consider the at_start effects when checking if actions A and B are parallelizable? Shouldn't it also consider the at_end effects?

What if action A has some over_all requirements that are affected by action B's at_end effects and action B finishes first?

// Apply the "at start" effects of the new action.
auto preds = predicates;
auto funcs = functions;
if (action.action.is_durative_action()) {
apply(action.action.get_at_start_effects(), preds, funcs);
}
// Check the requirements of the actions in the input set.
for (const auto & other : nodes) {
if (!is_action_executable(other->action, preds, funcs)) {
return false;
}
}

Rezenders added a commit to Rezenders/ros2_planning_system that referenced this issue Nov 5, 2024
@fmrico
Copy link
Contributor

fmrico commented Nov 8, 2024

Probably we could explore also this, but I don't remember the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants