Block delete reservation after its start time #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If start time of equipment or place passed current time, then block delete function
considering date, start_time when compare reservation time with current time
BlueHorn07
reviewed
Feb 9, 2024
Comment on lines
173
to
175
| if(reservation.start_time < new Date().toISOString()) { | ||
| throw new BadRequestException('Cannot delete past reservation'); | ||
| } |
There was a problem hiding this comment.
요렇게 바꿔보시죵
const reservation_start_time = reservation.date + reservation.start_time;
const current_time = moment().format('YYYYMMDDHHmm')
if(reservation_start_time < current_time) {
throw new BadRequestException('Cannot delete past reservation');
}그 아래 place reservation도 마찬가지!
And change variable name
|
dev에서 place와 equip 잘 되는 것 확인했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90 If start time of equipment or place passed current time, then block delete function