Improve documentation for Declaration methods #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
reviewed
Jan 24, 2024
There was a problem hiding this comment.
I tried to fix the
unused imports:
EnumVariantValue,NamedField,VisMarker
but it seems like they are referenced, by implement_span! macro invocations in the same file types_edition.rs.
Do you know why these warnings are being raised?
Other than that, this PR is good-to-go from my side.
|
Pushing a rebased version to see if the errors still appear... |
PoignardAzur
force-pushed
the
improve_doc
branch
from
618ab19 to
9989d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.