Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added message types to package exports #10

Merged
merged 4 commits into from
May 20, 2024

Conversation

stickyPiston
Copy link
Member

No description provided.

Copy link
Contributor

@Tjalle-S Tjalle-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik had deze expres niet geëxporteerd, omdat de messagetypes nooit nodig zijn (de receive*Message functies zouden genoeg moeten zijn)

@stickyPiston
Copy link
Member Author

stickyPiston commented May 6, 2024

In frontend-v2 heb ik die types wel nodig gehad buiten de receive*Message functies om, maar omdat de indeling van de vis-api veranderd is, moet de module resolution van frontend-v2 veranderen (in https://github.com/PolarExpress/frontend-v2/blob/main/libs/shared/tsconfig.json#L19) want "moduleResolution": "node" kan de message types niet vinden met de nieuwe indeling als ze niet expliciet geëxporteerd worden.

Sowieso staat de module resolution in frontend-v2 fout, want ze gebruiken een bundler en niet node. Dus het had eigenlijk uberhaupt niet mogen werken geloof ik.

@stickyPiston stickyPiston force-pushed the export-message-types branch 3 times, most recently from 4e766a2 to 84de8f3 Compare May 8, 2024 13:47
@stickyPiston stickyPiston force-pushed the export-message-types branch from 62409f9 to 1b1f1e0 Compare May 20, 2024 12:15
@stickyPiston stickyPiston merged commit 53dd3a0 into main May 20, 2024
4 checks passed
@stickyPiston stickyPiston deleted the export-message-types branch May 20, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants